✨ Support 16kb page size for Android 15+ devices

k-saparia commented 1 month ago

What feature or enhancement are you suggesting?

Description

I am encountering issues when running my app on Android 15 devices with a 16 KB page size, particularly with some native components. Are there any plans to recompile the library to address these issues and ensure compatibility with phones that have a 16 KB page size?

As stated on Android doc,

Beginning with Android 15, Android supports devices that are configured to use a page size of 16 KB (16 KB devices). If your app uses any NDK libraries, either directly or indirectly through an SDK, then you will need to rebuild your app for it to work on these 16 KB devices.

An analysis of my app using the APK Analyzer as described by Android shows that it does use libVisionCamera as native code.

This is the native binary reported by the APK analysis:

libVisionCamera.so

Describe the solution you'd like

I would like for libVisionCamera to support 16kb page size phones so that apps supporting sdk 35 do not crash

Additional context

Android doc: https://developer.android.com/guide/practices/page-sizes#compile-16-kb-alignment
react-native thread: https://github.com/facebook/react-native/issues/45054

What Platforms whould this feature/enhancement affect?

Android

Alternatives/Workarounds

No workaround I have investigated so far.

Additional information

[X] I agree to follow this project's Code of Conduct
[X] I searched for similar feature requests in this repository and found none.

maintenance-hans[bot] commented 1 month ago

Guten Tag, Hans here.

[!NOTE] New features, bugfixes, updates and other improvements are all handled mostly by @mrousavy in his free time. To support @mrousavy, please consider 💖 sponsoring him on GitHub 💖. Sponsored issues will be prioritized.

mrousavy commented 1 month ago

should be just a simple flag to CMake, but I think this will break backwards compat

k-saparia commented 1 month ago

If possible, It should be backward compatible with old and new architecture 🤔 Otherwise, worth to have a force update.

mrousavy commented 1 month ago

I'm talking about older android SDK/NDK versions

vishalyad16 commented 1 month ago

@k-saparia How can I reduce the size of a video that is 151 MB for a 1-minute recording? The bitRate setting does not seem to be working. https://github.com/mrousavy/react-native-vision-camera/issues/3113

mrousavy / react-native-vision-camera