Open frodriguez-hu opened 4 weeks ago
Guten Tag, Hans here! š»
Thanks for raising this issue. I see you have some concerns with the takePhoto
function. However, it seems that you did not provide relevant logs or specific reproduction steps that could help mrousavy diagnose the problem. Logs from adb logcat or specific errors will give much better insight.
Please share those logs, and be sure to check if the issue persists when you use the example app. If this issue remains after that and you gather more information, feel free to reopen it!
Also, if you find this project helpful, consider sponsoring mrousavy here to ensure continued support and updates!
Note: If you think I made a mistake, please ping
@mrousavy
to take a look.
@mrousavy Sorry to tag you I know it bothers you but the bot is asking me to do it
Another thing to mention is that when I set isMirrored
on false. the crop
works but with the image inverted
The code below it is working since it is using takeSnapshot, shouldn't work the same for takePhoto?
Those two funcs are implemented very differently - takeSnapshot uses the preview stream on Android and the video stream on iOS, and takePhoto uses a photo queue.
Did you examine the EXIF values? Maybe width and height represent physical pixel width/height of the image, and if it is using EXIF flags to rotate the image then the physical pixel width/height is represented before any EXIF orientations are considered.
@mrousavy I am also getting same issue with the takePhoto function
Also facing the same on Android
I'm having the same issue on Android.
It's a bit strange though as it works correctly on one Android device, but not the other. So on one device (Samsung A54), it is captured in landscape, and the final image is landscape. The other (Pixel 3) is captured in landscape, but the final image is portrait.
Using:
outputOrientation: 'preview'
any updates im facing the same issue
same here
What's happening?
I am doing the processing listed below to the photo taken by
takePhoto
ortakeSnapshot
.When I use
takePhoto
I have to invert theheight
andwidth
of the photo in order to make the calculations of the scale factors, that is happening on Android and IOS as well. Then in IOS it works fine, the x represents the X axis and the Y represents the y axis. But in android when I am going to crop the image, the X is modifying the Y axis and the Y modifying the X axis, I think that is an issue on how the photo that is coming fromtakePhoto
.But let's say it is okey and you handle that axis rotation, the Y axis is coming on a different proportion cause the cropping is cropping it in the middle of the face, which it should not happen like that. (Those are not issues from Image Editor cause it is working fine on other pictures).
The code below it is working since it is using
takeSnapshot
, shouldn't work the same fortakePhoto
?I think it is the same issue detailed here:
https://github.com/mrousavy/react-native-vision-camera/issues/2994
Reproduceable Code
Camera Device
Device
Samsung S21 plus
VisionCamera Version
4.5.0
Can you reproduce this issue in the VisionCamera Example app?
No, I cannot reproduce the issue in the Example app
Additional information