mrousavy / vision-camera-image-labeler

VisionCamera Frame Processor Plugin to label images using MLKit Vision
https://github.com/mrousavy/react-native-vision-camera
MIT License
119 stars 28 forks source link

chore: upgrade dependencies #25

Closed betomoedano closed 1 month ago

betomoedano commented 2 months ago

Vision Camera v4 Compatibility Update

Overview

This pull request aims to update the plugin for compatibility with Vision Camera v4. The initial work involves upgrading dependencies to their latest versions. However, I've encountered challenges with the VisionCameraImageLabeler.m file that require more advanced expertise in native development.

Changes Made

Current Blocker

The main obstacle is in VisionCameraImageLabeler.m. This file needs to be adapted for Vision Camera v4, but it requires in-depth knowledge of native iOS/Android development and the Vision Camera framework. Screenshot 2024-07-27 at 4 37 03 PM

Request for Assistance

@mrousavy was wondering if you can complete this change from here or guide me in the right direction.

Thank you!

mrousavy commented 2 months ago

hm that import should work - do you have VisionCamera as a pod dependency?

betomoedano commented 2 months ago

Yes, this is the podspec file. After adding VisionCamera as dependency I reinstalled pods running:

pod deintegrate
pod install

But same error 'VisionCamera/FrameProcessorPlugin.h' file not found not sure why

Screenshot 2024-07-28 at 7 55 45 AM

mrousavy commented 2 months ago

Heyo - sorry for the late reply, I had lots of stuff to do in other repos.

Are you sure Frame Processors are enabled in the example app? I definitely expose FrameProcessorPlugin.h and Frame.h as public headers in VisionCamera's podspec.

This is only ever skipped if frame processors are disabled. When running pod install VisionCamera logs whether frame processors are enabled or disabled, did you check that?

betomoedano commented 2 months ago

I'll double check that.

I just noticed that the example Podfile is targeting iOS 11. Maybe that's why is skipping frame processors when installing the pods.

I'll come back to this ASAP