mrozmanith / flexcairngorm

Automatically exported from code.google.com/p/flexcairngorm
0 stars 0 forks source link

Unused param in EventGenerator.initialize() #16

Open GoogleCodeExporter opened 8 years ago

GoogleCodeExporter commented 8 years ago
What steps will reproduce the problem?
1. Look at EventGenerator.initialize() code
2. Note that first param - "document" - isn't used by the code

     public function initialized(document:Object, id:String):void {
        this.id = id;
     }

Also, it would be great to get some clarification of how/when/why "id" is
meant to be used. It gets passed out by onAnnounceDone() and
onAnnounceFail(). Clearly the code using the EventGenerator can use this to
check which EventGenerator has failed or finished, which makes sense. But
why can't we pass this id value into the constructor? Why is it called
initialized() rather than initialize()? It looks at though this is a
not-completely-finished bit - and some clarification would be helpful.

But please take this pickiness within context - I love these extensions,
and appreciate the contribution!

Douglas

Original issue reported on code.google.com by douglas....@gmail.com on 3 Feb 2009 at 11:38

GoogleCodeExporter commented 8 years ago
"why can't we pass this id value into the constructor?"  To support 
instantiating via
mxml.

Original comment by alex.ros...@gmail.com on 9 Apr 2009 at 5:01