Modification(s?) to com.adobe.cairngorm code

[GoogleCodeExporter]

The version of Cairngorm 2.2.1 that you include is a bit different from the
code available from Adobe.

Adobe's ServiceLocator class has an "instance" prop.

The version you include has "__instance" instead.

Needless to say, this breaks things if a developer already has Adobe's
version in place, and just adds the com.universalmind.cairngorm code, as
UM's ServiceLocator references __instance.

Are there any other differences? Might be a good idea to run a diff and see
if there are any other changes to your version of the com.adobe.cairngorm
code...

(I'm assuming that you're using "normal" Cairngorm - not Cairngorm Enterprise.)

BTW, lest I seem to complain much, I appreciate your releasing this code.
Some good stuff here.  :)

Original issue reported on code.google.com by douglas....@gmail.com on 10 Apr 2008 at 6:24

[GoogleCodeExporter]

Aha! Now I see why you did this. Adobe's version has instance defined as 
private, and
you had to modify it and make it a protected property. I don't see a practical 
way
around this, so I'm guessing that you'll be keeping it. 

The project's home page explains that you include a version of the standard 
Cairngorm
code in your download - perhaps you should expand this a bit to mention this 
and any
other modifications.

Original comment by douglas....@gmail.com on 10 Apr 2008 at 6:35

[GoogleCodeExporter]

Or, could you just add a __instance prop to your ServiceLocator, and keep 
standard
Cairngorm standard?

Original comment by douglas....@gmail.com on 10 Apr 2008 at 4:34

[GoogleCodeExporter]

ServiceLocator (um version) now supports getInstance() and instance accessors.
Change to code in Adobe's ServiceLocator is still unresolved. 

Original comment by Thom...@Universalmind.com on 16 Apr 2008 at 7:03

• Changed state: Accepted