Method checkModuleType in FrontController

[GoogleCodeExporter]

Should this method not return true if it's a ModuleController?

      private function checkModuleType(subController:*):Boolean {
            if (subController is ModuleController) return false;
            else {
                var msg : String = "SubControllers must be subclasses of
ModuleController.";
                throw new Error( msg ); 
            }
      }

regards

Original issue reported on code.google.com by cyrill.z...@gmail.com on 15 Apr 2008 at 8:12

[GoogleCodeExporter]

I've run across this as well.  I believe it should return true so that
addSubController() can register the ModuleController's events and handlers.

-Andrew

Original comment by andrewwe...@gmail.com on 17 Jul 2008 at 6:25

[GoogleCodeExporter]

Any updated on this issue?

Original comment by brandon....@gmail.com on 12 Feb 2009 at 4:04

[GoogleCodeExporter]

Submitting a patch.  Compiled .swc + source files attached.

1) FrontController, line 122
CHANGE: if (subController is ModuleController) return false;
TO: if (subController is ModuleController) return true;

This will allow adding the sub-controller to proceed as expected.

2) ModuleController, line 90
CHANGE: for each (var eventID:String in commands) {
TO: for (var eventID:String in commands) {

This will grab the "key" from the dictionary instead of the "value".

Original comment by tsclaus...@gmail.com on 6 Mar 2009 at 10:13

Attachments:

• umcairngorm.swc
• FrontController.as
• ModuleController.as