Closed kherock closed 1 year ago
I don't think I can fix the test error showing in CI without splitting the *Reconcile
methods into separate create and update functions. Only the create function is supposed to show the expected validation error.
I was able to restore the original message! Would really appreciate a review on this one
@mrparkers sorry to be a bother, but could this be looked at soon?
Sorry, I meant to get to this before the latest release, but it slipped my mind.
This LGTM, I'll merge after tests pass and cut a release today.
Fixes #738
This brings the 404 handling of missing OpenID clients in line with the implementation for missing SAML clients when resolving client scopes. Basically, the validation of the 404 response was occurring too early, and the read context was throwing instead of return a blank ID via the
handleNotFound
handler.This also includes a similar fix for
generic_role_mapper
resources.The way that I tested these fixes was to configure a realm using these resource types, and run
terraform refresh
after manually deleting the realm.