mrparkers / terraform-provider-keycloak

Terraform provider for Keycloak
https://registry.terraform.io/providers/mrparkers/keycloak/latest/docs
MIT License
607 stars 295 forks source link

Feat: add LDAP custom mapper resource #863

Closed NataliaKhodiakova closed 8 months ago

NataliaKhodiakova commented 1 year ago

Added resource to configure self-deployed custom LDAP mapper (#862)

fixes: #862

punycode commented 1 year ago

Today, while working on terraforming a Keycloak installation for a customer, I came across the exactly same need and already wanted to fire up my Go IDE. Then I found this PR and can totally agree with the need for such a terraform resource.

I only have one additional thing to add: such a resource should support a map backed config attribute in the same way as keycloak_generic_protocol_mapper (code) does. This would be needed for some custom LDAP mappers, that need additional configuration.

NataliaKhodiakova commented 1 year ago

Hi @punycode thanks for the feedback! I added the optional config attribute to the resource

mrparkers commented 8 months ago

Hi @NataliaKhodiakova @punycode, sorry for the delay on this. I was able to pull this down and experiment with this locally. Thanks for adding the example and tests. Everything here looks great