Adds support for the ExcludeIssuerFromAuthResponse option on OpenIdClient

mrparkers / terraform-provider-keycloak

Terraform provider for Keycloak

https://registry.terraform.io/providers/mrparkers/keycloak/latest/docs

MIT License

592 stars 291 forks source link

Adds support for the ExcludeIssuerFromAuthResponse option on OpenIdClient #934

Open sebght opened 4 months ago

sebght commented 4 months ago

Solves https://github.com/mrparkers/terraform-provider-keycloak/issues/928

What has been changed :

new ExcludeIssuerFromAuthResponse attribute in the client
the resource schema is updated with ExcludeIssuerFromAuthResponse attribute
the datasource openid_client also returns this attribute
tests were updated + one new test case to check that the option is well updated
provider documentation returns the new attribute with the same words Keycloak uses

paul-pch commented 4 months ago

I've been struggling with this exat configuration. Thanks for the PR !

sebght commented 4 months ago

My tests have led me to think that the option is changed to false until it's not explicitly given to the API... This means everytime you terraform apply your client resource, it will set it back to false... Kind of a thorn in the side for ppl I guess (for me it is 😅). Should we consider a v4.4.1 @mrparkers ?

sebght commented 4 months ago

Nevermind, I did more precise tests and they prove that the option is not overwritten every apply. Sorry for the spamming !