mrpaulmason
commented
6 years ago totally get that the back & forth confused things here and most of that is on me. here's my suggestions moving forward (some obvious, some things we've missed), feel free to tweak.
- don't do any work without a ticket
- if it does happen (or you need more detail) create a ticket and assign to me
- when issues converge or split, create an add'l ticket and link back
- consider writing tickets with the planned work--when applicable--and i'll tweak/approve
- QA pretty much all your changes by going through the primary user flow:
hotline -> SURL -> landingpage -> tap the button - close tickets as work is completed, link to commit tickets
- check in with me anytime priorities appear to have shifted without clarity
darmai
forked from Hotline malfunctioning #131
I'd like some clarity on how the hotline a) got assigned as a relay and b) stopped sending the SURLs. I'm not worried if it was a miscommunication between us or a code miscue, but I'm surprised these things went undetected when all it takes is creating a SURL. If that's not part testing your changes, can we make it standard?
@darmai replied: Regarding a post-mortem on hotline not working as you expect, I think the first issue is that there was a discussion around the feature but no detailed ticket about how it should work. I focused my effort on Baton. As I was developing Baton, the point in the process where this assignment should happen changed. I
a) got assigned as a relay
I did not change the code to stop assigning the SURL request number as the meeting relay number. The number was being used as a place holder to be replaced later on in the process when Baton chose the actual relay number. You started using the hotline functionality (from what I can tell) before we ever had a conversation that it was fully implemented. Changes to Baton were inadvertently affecting hotline functionality. Now that Baton has stabilized this will not be an issue going forward.
b) stopped sending the SURLs
I wasn't testing hotline functionality because I had not yet focused on all of the details regarding implementing it. So, there is no test that would have caught this behavior as it wasn't where my focus was and I wasn't using the hotline for the tests that I was running to evaluate Baton.
If you check ticket #85, I never indicated that I had finished with this task as it was not on the list of April 10th priorities. If I indicated that hotline was ready to go, please point me to that communication and I can address that miscommunication.