search

mrpaulmason / meetable-api

Meetable API
1 stars 0 forks source link

TTC doesn't work from HTTPS LP #143

Closed mrpaulmason closed 6 years ago

mrpaulmason commented 6 years ago

i used http://meetable.ai/e1d93a to connect with Amalia using relay 347-609-7990 then I changed URL to https as a test, and tapping the button did nothing. Shouldn't it use the same relay number and push me into messages?

mrpaulmason commented 6 years ago

@darmai told @jmaj that the 'genrelay' API call is hard-coded into the page currently, possibly the root cause of this issue.

darmai commented 6 years ago

As soon as the API call on the landing page is changed to use https, I will change the API code to generate https SURL

mrpaulmason commented 6 years ago

@darmai correct me if i'm wrong but isn't this a case where you should create a ticket for that task and assign to @jmaj ? At this granular level I don't think a non-engineer should be doing this

darmai commented 6 years ago

I created a ticket in the meetable-ui repo to make the genrelay call use https. I then made the code change and linked the commit to that change. Finally, I changed the Meetable API to generate SURLs with https. Commit #149

The issue initially raised in this ticket is now resolved, so I am closing this issue.