Rendering places on map

mrpaulmason commented 6 years ago

separating this task from legacy ticket #21

when places endpoint is complete #154..build the following on our map

[x] 1. URL rendering all of our coffee locations
[x] 2. URL rendering all our drinks locations
[ ] 3. locations now have hover and click events
[ ] 4. to test onclick events open the js console and click on a location, you should see location's name appear
[ ] 5. filter between coffee and drinks category (via button if easy, otherwise URL

darmai commented 6 years ago

Coffee locations are now being rendered after the following commits in meetable-ui repo:

https://github.com/mrpaulmason/meetable-ui/pull/7 https://github.com/mrpaulmason/meetable-ui/pull/8 https://github.com/mrpaulmason/meetable-ui/pull/9

darmai commented 6 years ago

@mrpaulmason Saw that a new task was added here (#4). Providing a URL to filter for drinks is trivial

http://meetable-api.herokuapp.com/places?category=drinks

A button that toggles between the two categories should be pretty easy to add. What would you like the text to be on the button and where would you want it to be located?

mrpaulmason commented 6 years ago

That URL returns raw text, i’m asking for a URL for a map containing the drinks places.

Lets hold off on buttons until after attribute filtering is built.

mrpaulmason commented 6 years ago

To clarify, I'd like to see a map of all the drinks places (to determine if more are needed) and i've added this as a priority in the top comment.

If the least effort way to do this is a URL path like meetable.ai/map?category=drinks|coffee that's ideal because it removes the need for the button entirely.

If there's an easier way let me know and we'll do that.

darmai commented 6 years ago

Ah. I get it. So, currently the map only ever shows coffee places because of the form of the url being called on the page. Its structured in a static way. I assumed the call would eventually be dynamic and the filtering criteria would be passed into the url used to call the meetable API for the list of places.

A url on for meetable.ai which specifies the category to use in the call to the API is the simplest way to handle this in my opinion. There would be no need for a button (for now) with this setup. I'll implement support for meetable.ai/map?category=drinks|coffee

darmai commented 6 years ago

Filtering by coffee or drinks is now handled by query strings using map url based on this commit https://github.com/mrpaulmason/meetable-ui/pull/10

Url for viewing all coffee shops: http://localhost:3000/map?category=coffee Url for viewing all drinks places: http://localhost:3000/map?category=drinks Default when no category provided (e.g., http://localhost:3000/map or http://localhost:3000/map/1) is to show all coffee shops

darmai commented 6 years ago

@mrpaulmason How important is this task of having places support hover events? I'm having some trouble figuring out how to re-enable that functionality. Its not clear from the react-google-maps documentation or the previous commits how the hover code should work. And I'm not sure the benefit of figuring this out will be worth the time its taking to get this working.

Let me know what you think.

mrpaulmason commented 6 years ago

Not that important at all. Closing the ticket

mrpaulmason / meetable-api

Rendering places on map #156