mrpdaemon / encdroid

Encdroid is an Android application for accessing EncFS volumes on cloud storage
GNU General Public License v3.0
86 stars 20 forks source link

Fix logging exceptions with empty messages #25

Closed mrpdaemon closed 11 years ago

mrpdaemon commented 11 years ago

Got the following backtrace from Google Developer console with Encdroid 1.3:

java.lang.RuntimeException: An error occured while executing doInBackground() at android.os.AsyncTask$3.done(AsyncTask.java:200) at java.util.concurrent.FutureTask$Sync.innerSetException(FutureTask.java:274) at java.util.concurrent.FutureTask.setException(FutureTask.java:125) at java.util.concurrent.FutureTask$Sync.innerRun(FutureTask.java:308) at java.util.concurrent.FutureTask.run(FutureTask.java:138) at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1088) at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:581) at java.lang.Thread.run(Thread.java:1019) Caused by: java.lang.NullPointerException: println needs a message at android.util.Log.println_native(Native Method) at android.util.Log.e(Log.java:371) at org.mrpdaemon.android.encdroid.EDVolumeListActivity$EDUnlockVolumeTask.doInBackground(EDVolumeListActivity.java:926) at org.mrpdaemon.android.encdroid.EDVolumeListActivity$EDUnlockVolumeTask.doInBackground(EDVolumeListActivity.java:1) at android.os.AsyncTask$2.call(AsyncTask.java:185) at java.util.concurrent.FutureTask$Sync.innerRun(FutureTask.java:306) ... 4 more

Looks like the exception has an empty message which upsets Log.e().

mrpdaemon commented 11 years ago

Fixed at d62888d1447156903ce79fdaeb4088346be13c42