search

mrpdaemon / encdroid

Encdroid is an Android application for accessing EncFS volumes on cloud storage
GNU General Public License v3.0
86 stars 20 forks source link

Crash when using long press menu of list header of VolumeBrowserActivity #53

Closed mrpdaemon closed 10 years ago

mrpdaemon commented 10 years ago

The list header (which shows the current volume path) can be long pressed and the context menu is shown (shouldn't be shown). Clicking some items like "Delete" on the context menu cause a crash. This was reported through Google Developer Console.

java.lang.ArrayIndexOutOfBoundsException: length=57; index=-1 at java.util.ArrayList.get(ArrayList.java:306) at org.mrpdaemon.android.encdroid.FileChooserAdapter.getItem(FileChooserAdapter.java:46) at org.mrpdaemon.android.encdroid.VolumeBrowserActivity.onContextItemSelected(VolumeBrowserActivity.java:815) at android.app.Activity.onMenuItemSelected(Activity.java:2566) at com.android.internal.policy.impl.PhoneWindow$DialogMenuCallback.onMenuItemSelected(PhoneWindow.java:3633) at com.android.internal.view.menu.MenuBuilder.dispatchMenuItemSelected(MenuBuilder.java:735) at com.android.internal.view.menu.MenuItemImpl.invoke(MenuItemImpl.java:149) at com.android.internal.view.menu.MenuBuilder.performItemAction(MenuBuilder.java:874) at com.android.internal.view.menu.MenuDialogHelper.onClick(MenuDialogHelper.java:167) at com.android.internal.app.AlertController$AlertParams$3.onItemClick(AlertController.java:941) at android.widget.AdapterView.performItemClick(AdapterView.java:298) at android.widget.AbsListView.performItemClick(AbsListView.java:1100) at android.widget.AbsListView$PerformClick.run(AbsListView.java:2749) at android.widget.AbsListView$1.run(AbsListView.java:3423) at android.os.Handler.handleCallback(Handler.java:725) at android.os.Handler.dispatchMessage(Handler.java:92) at android.os.Looper.loop(Looper.java:137) at android.app.ActivityThread.main(ActivityThread.java:5041) at java.lang.reflect.Method.invokeNative(Native Method) at java.lang.reflect.Method.invoke(Method.java:511) at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:817) at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:584) at dalvik.system.NativeStart.main(Native Method)

mrpdaemon commented 10 years ago

Fixed at e68026ca9476f131fecfea08d011cf9e12286d6e