search

mrpdaemon / encdroid

Encdroid is an Android application for accessing EncFS volumes on cloud storage
GNU General Public License v3.0
86 stars 20 forks source link

Feature: Adding Custom config file provision. #67

Closed ashjas closed 10 years ago

ashjas commented 10 years ago

This patch takes care of issue #41 Adds a way to browse custom config file. I've tried to make minimal changes to existing ui. This patch only does this for local encfs volumes as of now.Tried for dropbox and drive too but for some unknown reason couldn't connect to any cloud accounts here. Would definitely add once I figure out the issue.

smessmer commented 10 years ago

cool, need this feature :)

Did you make progress for non-local volumes? My use case would be having the encrypted volume on dropbox/google drive, but having the encfs6.conf locally.

mrpdaemon commented 10 years ago

Ashjas, thanks for your work. I'll review / try out your changes and hopefully merge them in.

ashjas commented 10 years ago

@smessmer yes. the next commit in the pull does that for cloud volumes too.

mrpdaemon commented 10 years ago

I'm getting a crash when testing upgrade of the app from an older version:

07-13 04:09:27.738: E/AndroidRuntime(1905): FATAL EXCEPTION: main 07-13 04:09:27.738: E/AndroidRuntime(1905): Process: org.mrpdaemon.android.encdroid, PID: 1905 07-13 04:09:27.738: E/AndroidRuntime(1905): java.lang.RuntimeException: Unable to create application org.mrpdaemon.android.encdroid.EDApplication: java.lang.IllegalStateException: Couldn't read row 0, col -1 from CursorWindow. Make sure the Cursor is initialized correctly before accessing data from it. 07-13 04:09:27.738: E/AndroidRuntime(1905): at android.app.ActivityThread.handleBindApplication(ActivityThread.java:4347) 07-13 04:09:27.738: E/AndroidRuntime(1905): at android.app.ActivityThread.access$1500(ActivityThread.java:135) 07-13 04:09:27.738: E/AndroidRuntime(1905): at android.app.ActivityThread$H.handleMessage(ActivityThread.java:1256) 07-13 04:09:27.738: E/AndroidRuntime(1905): at android.os.Handler.dispatchMessage(Handler.java:102) 07-13 04:09:27.738: E/AndroidRuntime(1905): at android.os.Looper.loop(Looper.java:136) 07-13 04:09:27.738: E/AndroidRuntime(1905): at android.app.ActivityThread.main(ActivityThread.java:5017) 07-13 04:09:27.738: E/AndroidRuntime(1905): at java.lang.reflect.Method.invokeNative(Native Method) 07-13 04:09:27.738: E/AndroidRuntime(1905): at java.lang.reflect.Method.invoke(Method.java:515) 07-13 04:09:27.738: E/AndroidRuntime(1905): at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:779) 07-13 04:09:27.738: E/AndroidRuntime(1905): at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:595) 07-13 04:09:27.738: E/AndroidRuntime(1905): at dalvik.system.NativeStart.main(Native Method) 07-13 04:09:27.738: E/AndroidRuntime(1905): Caused by: java.lang.IllegalStateException: Couldn't read row 0, col -1 from CursorWindow. Make sure the Cursor is initialized correctly before accessing data from it. 07-13 04:09:27.738: E/AndroidRuntime(1905): at android.database.CursorWindow.nativeGetString(Native Method) 07-13 04:09:27.738: E/AndroidRuntime(1905): at android.database.CursorWindow.getString(CursorWindow.java:434) 07-13 04:09:27.738: E/AndroidRuntime(1905): at android.database.AbstractWindowedCursor.getString(AbstractWindowedCursor.java:51) 07-13 04:09:27.738: E/AndroidRuntime(1905): at org.mrpdaemon.android.encdroid.DBHelper.getVolumes(DBHelper.java:182) 07-13 04:09:27.738: E/AndroidRuntime(1905): at org.mrpdaemon.android.encdroid.EDApplication.onCreate(EDApplication.java:92) 07-13 04:09:27.738: E/AndroidRuntime(1905): at android.app.Instrumentation.callApplicationOnCreate(Instrumentation.java:1007) 07-13 04:09:27.738: E/AndroidRuntime(1905): at android.app.ActivityThread.handleBindApplication(ActivityThread.java:4344) 07-13 04:09:27.738: E/AndroidRuntime(1905): ... 10 more

I believe your changes to the DBHelper.java don't properly handle the upgrade case?

mrpdaemon commented 10 years ago

Also please fix formatting by running the Eclipse auto format (Source -> Format) on all your changes.

mrpdaemon commented 10 years ago

I've merged your work - thanks for the contribution! I'm hoping to release this as part of the 2.1 release within a few weeks. If you're interested in contributing more I'd be very happy to review and merge more changes :)

ashjas commented 10 years ago

Thanks for the merge. I feel great that I could be of some help to so many people that use your excellent application. I would be more than happy if i repeat this in the future. :)

smessmer commented 9 years ago

Is the 2.1 release coming soon? I'm very looking forward to having this feature :)

mrpdaemon commented 9 years ago

Yes, sorry for the delay. I've been working on support for multiple file selection and am polishing a few remaining UI issues - I will do a 2.1 release relatively soon.