search

mrpdaemon / encfs-java

encfs-java is a Java library for accessing data in EncFS volumes
GNU Lesser General Public License v3.0
42 stars 15 forks source link

add support to rename files (using the example shell) #5

Closed aefo closed 12 years ago

aefo commented 12 years ago

will require calculating the new file name based on the unencoded name the user enters

(first step towards read/write...getting file name generation working)

aefo commented 12 years ago

I've got a local version that seems to do the file name encryption. remaining item is to write the base64 encoding (reverse of EncFSBase64.decodeEncfs()) for the encrypted name

mrpdaemon commented 12 years ago

Great. One thing to consider is that isChainedIV() mode is considerably trickier, need to recursively rename all files/directories under the affected file.

aefo commented 12 years ago

Yep -- at the moment, I'm must looking at getting the file renames working. When we do directory renames will certainly need to think about this.

I think the 'safe' way that you have to do it is by doing create new directory & move the files from the original in to the new directory rather than doing rename directory & then files within the directory Otherwise if for any reason the operations fails halfway through (either crash, file error or killed), there is the potential that you can't recover some of the files that have names based on the original directory name.

mrpdaemon commented 12 years ago

Andrew, what is the status on this? Renames working properly for configurations like chained IV ? Tests in place? If so lets just close this.

aefo commented 12 years ago

The rename support should be there (including chained IV), but I still need to add the tests....

Will try and get then in,

Andrew

From: mrpdaemon reply@reply.github.com Sent: Fri Feb 10 08:24:14 GMT 2012 To: aefo aefo-dev@ormerods.net Subject: Re: [encfs-java] add support to rename files (using the example shell) (#5)

Andrew, what is the status on this? Renames working properly for configurations like chained IV ? Tests in place? If so lets just close this.

Reply to this email directly or view it on GitHub: https://github.com/mrpdaemon/encfs-java/issues/5#issuecomment-3902789

mrpdaemon commented 12 years ago

I created issue 13 to support volume creation - I think that would be a nice facility for tests, especially the ones that modify the volume, we don't really want them to operate on the sample volumes, if there are bugs we might end up messing up the sample volume. Creating a new temp volume for write mode tests sounds better.

mrpdaemon commented 12 years ago

Fixed issue 13 with commit b4d230dac7 - you should be able to add a rename test using temporary volume creation :)

mrpdaemon commented 12 years ago

This was fixed, EncFSVolumeTest has rename tests.