search

mrpeardotnet / WinProdKeyFinder

Windows Product Key Finder written in C#.
http://www.mrpear.net
MIT License
129 stars 42 forks source link

Unnecessary code? #7

Closed paul35621 closed 1 year ago

paul35621 commented 5 years ago

It seems that you can remove | (isWin8 & 2) * 4) in KeyDecoder.cs. Since isWin8 = ... & 1 it's always true that isWin8 & 2 == 0. Right?

hobbygramerpro commented 3 years ago

Exactly! isWin8 is either 0 or 1, hence isWin8 & 2 is always 0. But in that case, what is the variable even doing there?

mrpeardotnet commented 1 year ago

It is just about the part of a code, not functionality. No need to fix.