search

mrphlip / lrrbot

LoadingReadyRun Twitch chatbot
https://lrrbot.com/
Apache License 2.0
30 stars 20 forks source link

Replay titles and played game occasionally wrong #111

Open andreasots opened 9 years ago

andreasots commented 9 years ago

Exhibit A: A strange Bloodborne mod

Exhibit B: GPLP == ASTC

d3fr0st commented 9 years ago

Cam pls

Though the issue is twitch probably twitch polling the title/game for the replay before the streamer changes it, cause it's also wrong on twitch.

RebelliousUno commented 9 years ago

It's likely the streamer forgetting to change the stream title/game at the start of their stream?

d3fr0st commented 9 years ago

I can edit the replay to properly be titled and have the correct game... lemme just do that and see if it fixes it on our end. (Exhibit A fixed waiting for bot to pull exhibit B)

d3fr0st commented 9 years ago

I'm gonna go with user error on this one... nothing that we can do about

mrphlip commented 9 years ago

Brainstorming: How feasible do you think it would be to store in the DB every time the game/show/stream title changes, and have the archive page/feed show the one that was shown for the longest, rather than using what comes from Twitch (which is iirc just whatever it was when the stream started). Could even show a list of every game played in the time, good for shows like W+P...

d3fr0st commented 9 years ago

We could, maybe record every time a game changes and cross-check between that list and replay start time through replay start time + length. Though we'd have to be careful in case the streamer changes the game early... Same could be done with the title. Though if something like this is implemented we'd really need an interface to change the title/game for mods

RebelliousUno commented 9 years ago

What about tracking based on the !game that lrrbot keeps track of? Since then we have the ability to use !game override for when things show up (in the middle of a draft for instance?) Everytime !game changes take a snapshot of the time/date and title at that point?

d3fr0st commented 9 years ago

Well we poll twitch Api a lot if we compared the current game name to the last entry we could probably get a more accurate list than !Game

If gamename != record.last
   Record.Add(gamename, time, streamtitle)

*not proper code I know but it's an insanely simple if statement... That should be able to be done often

Parsing said list into the replay list could be the harder part of this problem

AdmiralMemo commented 9 years ago

It's likely streamer error, but it could also be Twitch error, as I've seen plenty of times where the streamer clicks their "Update" button, and then fails to notice the small error box telling them that their update failed to go through. Usually, that is resolved mid-stream, which might give us this issue, regarding which "title" to use.

andreasots commented 8 years ago

Twitch, pls

AdmiralMemo commented 8 years ago

Well, that's the title and game he started on and played for 2 hours, so there's that.

AdmiralMemo commented 8 years ago

Apparently, not just titles/games anymore... lrrboterror

CharlesFD commented 8 years ago

There was a hiccup with the VOD system on that day. I have seen a few different VOD's with odd times (missing on mobile) for that day. Is that the only one?

Also Ref: https://twitter.com/TwitchSupport/status/670043505650200576

mrphlip commented 8 years ago

The LRRMtG VOD from later that day is also fairly messed up, with some significant chunks missing during the drafting portion... Not much to be done about it, I'm afraid, but wait until the YT version is uploaded from LRR's recordings... assuming they still do those...