search

mrpierrot / cycle-node-http-server

Driver and router component for manage HTTP/HTTPS services with Cycle.js
Other
6 stars 3 forks source link

fix README.md router example #1

Closed fabienjuif closed 7 years ago

fabienjuif commented 7 years ago

Hi,

Nice work, this is funny to test CycleJS to the server side :)

I open this PR since the Router example was not working, I think you made a little mistake : sources are not added to parameter of Page component since the Page component is called before your Router handle it.

I used Object.assign instead of object spread operator because Node doesn't support them out of the box by now.

My VSCode config trim spaces, maybe I can change that if you want to.

mrpierrot commented 7 years ago

Hi,

Thanks for this PR :-) If you want, you can also try this https://github.com/mrpierrot/cycle-net/tree/2.0.0 It's not yet documented ( sorry ) but this is drivers for http wit router ( like this lib ) + websocket + socket.io. You can see examples in test folder.

French Et si jamais tu viens au Dev Fest ou à NantesJS, on pourra en discuter avec plaisir :-)