Closed hillin closed 2 years ago
(Background: we are writing a middleware and wish that some of the effect classes used by the middleware are not automatically registered by Fluxor, rather let the middleware to control them).
I'm unable to reproduce this.
The exclusion works on namespace. Is the namespace of the effect either the same or a sub of the namespace the middleware is in?
Can you provide a repro for this?
I'll close this for now. If you manage to create a repro then please post a link to it and I'll reopen.
The intention of the following code snippet, if I understand correctly, an IEffect (as well as other auto-registerable types) that is placed under the namespace where a middleware resides will be excluded in the types to be automatically registered: https://github.com/mrpmorris/Fluxor/blob/65a96b579af82387ddddacb50d7c76a3b6b3b377/Source/Fluxor/DependencyInjection/ReflectionScanner.cs#L92-L107
However from the implementation of
AssemblyScanSettings.FilterClasses
below we can see they are not effectively excluded: https://github.com/mrpmorris/Fluxor/blob/65a96b579af82387ddddacb50d7c76a3b6b3b377/Source/Fluxor/DependencyInjection/AssemblyScanSettings.cs#L29-L37I think the
||
in line 36 should be&&
.