Remove the print Athena function - Githubissues

mrpowers-io / quinn

pyspark methods to enhance developer productivity 📣 👯 🎉

https://mrpowers-io.github.io/quinn/

Apache License 2.0

645 stars 99 forks source link

Remove the print Athena function #236

Closed nijanthanvijayakumar closed 4 months ago

nijanthanvijayakumar commented 4 months ago

Proposed changes

This PR is related to the #199 and does the following:

Remove the print_athena_create_table function
- According to one of the points in the issue #199 by @MrPowers, this function should never have been created.
- This particular commit removes this function and its references from the quinn repo.

Types of changes

[ ] Bugfix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[x] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Documentation Update (if none of the other choices apply)

Further comments

Does not close the issue #199 as there are other open items in that. However, addresses one of the points i.e.,

get rid of functions that should have never been added (e.g. print_athena_create_table

nijanthanvijayakumar commented 4 months ago

@MrPowers and @SemyonSinchenko - added another PR to address one of the points in the issue: #199

Please let me know your thoughts.