mrprotocoll / meal-app

This is a single webpage that displays meals froma an API and enable users to like, view meal details and comment.
MIT License
3 stars 0 forks source link

Milestone :Group capstone project set up your Kanban board #21

Open Lancelot-SO opened 1 year ago

Lancelot-SO commented 1 year ago

Link to GitHub projects

https://github.com/mrprotocoll/kanban-capstone-project/projects/1

Partners involved

Number of partners

2

Partners

@mrprotocoll - Student A @Lancelot-SO - Student B

Nemwel-Boniface commented 1 year ago

Hello @Lancelot-SO and @mrprotocoll :wave: ,

I'm Nemwel your reviewer for this PR :man_beard:

Good job working on your project so far! :clap: There are some issues that you still need to work on to go to the next project but you are almost there!

Highlights

Great job setting up the correct linters ✔️ Professional documentation ✔️ Correct workflow ✔️ Meaningful commit messages ✔️

♻️ Required Changes ♻️

This is how your kanban board looks like:

image

Check the comments under the review.

[Optional] suggestions

Every comment with the [OPTIONAL] prefix is not crucial enough to stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better.

Cheers and Happy coding! :partying_face: 👏👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear. Please, remember to tag me @Nemwel-Boniface in your question so I can receive the notification.

Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.


As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

Lancelot-SO commented 1 year ago

Thank you for the review

Below is a screenshot of the requested corrections

image

pinkmoon25 commented 1 year ago

Hi @Lancelot-SO and @mrprotocoll ,

Your project is complete! There is nothing else to say other than... it's time to merge it :shipit: Congratulations! 🎉

Highlights

Kanban board setup :heavy_check_mark:

Optional suggestions

Every comment with the [OPTIONAL] prefix won't stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better. Some of them were simply missed by the previous reviewer and addressing them will really improve your application.

Cheers and Happy coding!👏👏👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear. Please, remember to tag me in your question so I can receive the notification.


As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.