[Noetic] mrpt_sensorlib fails to build on build farm: ‘now’ is not a member of ‘mrpt::system’

sloretz commented 7 months ago

https://build.ros.org/job/Nbin_uF64__mrpt_sensorlib__ubuntu_focal_amd64__binary/49/console

23:08:28 /tmp/binarydeb/ros-noetic-mrpt-sensorlib-0.0.3/src/mrpt_sensorlib.cpp: In member function ‘virtual void mrpt_sensorlib::GenericSensorNode::internal_init()’:
23:08:35 /tmp/binarydeb/ros-noetic-mrpt-sensorlib-0.0.3/src/mrpt_sensorlib.cpp:62:49: error: ‘now’ is not a member of ‘mrpt::system’
23:08:35    62 |    mrpt::system::timestampToParts(mrpt::system::now(), parts, true);
23:08:35       |                                                 ^~~

The same issue also causes these package to fail to build: mrpt_path_planning, mrpt_reactivenav2d, and mrpt_rawlog

https://github.com/MRPT/mrpt_path_planning/issues/13 https://github.com/mrpt-ros-pkg/mrpt_navigation/issues/142

jlblancoc commented 7 months ago

This can be fixed building against mrpt2 v2.12.0. Perhaps I forgot releasing it for noetic??

jlblancoc commented 7 months ago

Oh my bad! Mrpt2 was updated but I must make new releases for all projects downstream. I'll do it asap.

jlblancoc commented 7 months ago

Fixed with https://github.com/ros/rosdistro/pull/40266

mrpt-ros-pkg / mrpt_sensors

[Noetic] mrpt_sensorlib fails to build on build farm: ‘now’ is not a member of ‘mrpt::system’ #3