search

mrpt-ros-pkg / mrpt_slam

ROS wrappers for SLAM algorithms in MRPT
http://wiki.ros.org/mrpt_slam
BSD 3-Clause "New" or "Revised" License
114 stars 49 forks source link

Enhance mrpt_graphslam_2d package #16

Closed bergercookie closed 7 years ago

bergercookie commented 7 years ago

current PR:

bergercookie commented 7 years ago

@jlblancoc take a look at this. If you are OK with the changes I suppose we could merge this.

P.S. Not very comfortable merging my own PRs just yet. :-)

jlblancoc commented 7 years ago

Ok!

How do you read class_verbosity from the config files? I mean: there is a method for reading enum values capable of interpreting textual values, much easier and clearer to the user than numbers... See here the mapping between strings (that you can put in those ini files) and values.

Apart from that, go on, merge this and do this little change, or the other way around.

bergercookie commented 7 years ago

How do you read class_verbosity from the config files? I mean: there is a method for reading enum values capable of interpreting textual values, much easier and clearer to the user than numbers... See here the mapping between strings (that you can put in those ini files) and values.

This is not specific to the mrpt_graphslam_2d application, is it? I mean, class_verbosity exists both as a ROS Parameter server (this is used just for the verbosity of the MPRT_LOG* directives of the ros-related files and as a .ini variable in the .ini file passed to the CGraphSlamEngine class. For the latter this could indeed come in handy so that I don't just write numerical values for verbosity.