search

mrpt-ros-pkg / mrpt_slam

ROS wrappers for SLAM algorithms in MRPT
http://wiki.ros.org/mrpt_slam
BSD 3-Clause "New" or "Revised" License
114 stars 49 forks source link

mrpt>=1.3.0 slam vs obs/maps issue #5

Closed nbanyk closed 8 years ago

nbanyk commented 8 years ago

I think that this might solve the old vs new mrpt libraries version issue (mentioned here: https://github.com/mrpt-ros-pkg/mrpt_slam/pull/4)

nbanyk commented 8 years ago

Closing this as there was another Travis error.

nbanyk commented 8 years ago

Ok, I see what the issue is. The mrpt_ro_slam package requires the empty constructor/copy operator change I made to CMetricMapBuilderRBPF in mrpt. So that's why it's not going to work with older versions of mrpt. I couldn't figure out a way to give more global-like access to the CMetricMapBuilderRBPF object that I created (in mrpt_ro_slam.h) without this. Unless I learn a better way to do that, then I won't be able to fix this.

jlblancoc commented 8 years ago

What about defining it as a pointer (CMetricMapBuilderRBPF *) so it can be constructed with new CMetricMapBuilderRBPF (...) when needed, and delete ...;'d at destructor?

Logrus commented 8 years ago

Concerning travis build, I think we need to add a new line to .travis.yml. I made a PR https://github.com/mrpt-ros-pkg/mrpt_slam/pull/6. I tested new .travis.yml with this pull request and it builds (https://travis-ci.org/Logrus/mrpt_slam/builds/120088179). This PR can be rebased on the master after merging https://github.com/mrpt-ros-pkg/mrpt_slam/pull/6 then we can make sure it builds. But it seems to be working already, so that the problem here is just in travis config.

jlblancoc commented 8 years ago

Great!!

nbanyk commented 8 years ago

Thanks!