search

mrpt-ros-pkg / mrpt_slam

ROS wrappers for SLAM algorithms in MRPT
http://wiki.ros.org/mrpt_slam
BSD 3-Clause "New" or "Revised" License
114 stars 49 forks source link

Missing csl_common dependency found in .launch #57

Closed andersfischernielsen closed 5 years ago

andersfischernielsen commented 5 years ago

I'm currently doing some research on static analysis of ROS packages at the IT University of Copenhagen, more specifically dependency checking of .launch files in ROS packages.

There seems to be a $(find csl_common) in

Installing mrpt_slam without having csl_common installed would make roslaunch fail on this .launch file, right?

I'm unsure whether this is a dependency bug, since it is only in one specific demo configuration. Nonetheless, roslaunch would fail, right?

jlblancoc commented 5 years ago

I'm pinging Nikos for this one :-) @bergercookie

The line is: 

 <!-- Run multimaster -->
    <include file="$(find csl_common)/launch/setup_multimaster.launch" />

What is csl_common?

bergercookie commented 5 years ago

Um, I'd give the same answer as in the mrpt_navigation case. I mean, this demo exists only for the multi-robot SLAM case in which we 've already documented that the csl_mr_slam package suite. If there was something better than <depends> package xml tag that's suited for this kind of dependencies I'd be happy to use it though.

What is csl_common?

It's one of the csl_mr_slam packages needed for the MR demo

On Thu, 4 Apr 2019 at 23:31, Jose Luis Blanco-Claraco < notifications@github.com> wrote:

I'm pinging Nikos for this one :-) @bergercookie https://github.com/bergercookie

The line is:

  <include file="$(find csl_common)/launch/setup_multimaster.launch" />

What is csl_common?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/mrpt-ros-pkg/mrpt_slam/issues/57#issuecomment-480087005, or mute the thread https://github.com/notifications/unsubscribe-auth/AFjBj-PfAIYTvSR9AxqsBmtb8Ok748K0ks5vdn1PgaJpZM4cZN4v .

-- Nikos Koukis nickkouk@gmail.com +44 7902907732

jlblancoc commented 5 years ago

Alright... then, let's mark this as "won't fix", since we don't have anything better than "Depends" on package.xmls... ;-) Cheers!