search

mrrfv / open-android-backup

Back up your device without vendor lock-ins, using insecure software or root. Supports encryption and compression out of the box. Works cross-platform.
http://openandroidbackup.me/
GNU General Public License v3.0
674 stars 37 forks source link

proposed changes from shellcheck #28

Closed mikedlr closed 1 year ago

mikedlr commented 1 year ago

shellcheck is a neat tool to help improve the security and stability of shell scripts. I tried running it and it proposed these fixes to the backup script.

shellcheck -f diff backup.sh | git apply

If you like them it might also be worth doing shellcheck on all of the other bash scripts in the repository

Here are the remaining unfixed warnings from the backup.sh script when run as

shellcheck backup.sh

shellcheck-out.txt

mrrfv commented 1 year ago

Thanks for the pull request! I applied the proposed fixes in the latest commit.