search

mrrfv / open-android-backup

Back up your device without vendor lock-ins, using insecure software or root. Supports encryption and compression out of the box. Works cross-platform.
http://openandroidbackup.me/
GNU General Public License v3.0
674 stars 37 forks source link

get_text_input prompt result_var #61

Closed dajix350 closed 1 year ago

dajix350 commented 1 year ago

Device info

Manufacturer: Nokia Android version: 11 Custom ROM/rooted? No, vanilla Android One Model: 2.3

System info

Available disk space: 65 GB on home partition, 11 on root. Operating system: Debian Bookworm

Describe the issue below. I am trying to run the script, but it is crashing at this step on both tar and adb mode.

Open Android Backup will install a companion app on your device, which will allow for contacts and other data to be backed up and restored.
The companion app is open-source, and you can see what it's doing under the hood on GitHub.
Companion app already downloaded.
Attempting to uninstall companion app.
Installing companion app.
Performing Streamed Install
Success
Granting required permissions to companion app.
Cleaning up after backup/restore...
Securely erasing temporary files, this will take a while.
Using /dev/urandom for random input.
Wipe mode is insecure (two passes [0xff/random])
Wiping ./backup-tmp DIRECTORY (going recursive now)
Removed directory ./backup-tmp ... Done
Cleanup complete.
Invalid usage. Usage: get_text_input prompt result_var [default_text]

After that, I just return to my regular prompt.

mrrfv commented 1 year ago

Assuming that you are backing up and not restoring. I just made a tiny fix that might fix this issue - could you please git clone or download the master branch of this repository and see if it resolves the problem? If it does, please reply and/or close this issue so I can make a stable release including the patch.

dajix350 commented 1 year ago

I had the same crash still.

Open Android Backup will install a companion app on your device, which will allow for contacts and other data to be backed up and restored.
The companion app is open-source, and you can see what it's doing under the hood on GitHub.
Downloading companion app.
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
  0 17.6M    0   826    0     0    824      0  6:14:08  0:00:01  6:14  6 17.6M    6 1167k    0     0   860k      0  0:00:20  0:00:01  0:00 24 17.6M   24 4431k    0     0  1881k      0  0:00:09  0:00:02  0:00 42 17.6M   42 7711k    0     0  2298k      0  0:00:07  0:00:03  0:00 61 17.6M   61 10.7M    0     0  2533k      0  0:00:07  0:00:04  0:00 79 17.6M   79 13.9M    0     0  2676k      0  0:00:06  0:00:05  0:00 94 17.6M   94 16.6M    0     0  2677k      0  0:00:06  0:00:06 --:--100 17.6M  100 17.6M    0     0  2710k      0  0:00:06  0:00:06 --:--:-- 3164k
Stable version downloaded successfully
Attempting to uninstall companion app.
Installing companion app.
Performing Streamed Install
Success
Granting required permissions to companion app.
Couldn't find any temporary files to cleanup, continuing. This is not an error.
Invalid usage. Usage: get_text_input prompt result_var [default_text]
dajix350 commented 1 year ago

For what it's worth, I think I have backed up this phone using this tool in the past

redno2 commented 1 year ago

I'm affected too with this bug on my samsung s9+, might be linked to the new kdialog usage. on the v1.0.6 it seem to work

mrrfv commented 1 year ago

kdialog is only used on Windows and has been thoroughly tested.

mrrfv commented 1 year ago

Made another patch that might fix this. Could anyone try using v1.0.8 (latest version)?

Edit, 20 hours later: I was just able to test v1.0.8 and it appears to be working for me.

mrrfv commented 1 year ago

Closing due to inactivity. Please let me know if the issue persists, and I will reopen.