search

mrrwa / LocoNet

An embedded Loconet interface library for Arduino family microcontrollers
Other
68 stars 32 forks source link

Make all methods of LocoNetSystemVariableClass public #15

Closed evili closed 4 years ago

evili commented 4 years ago

Hi,

IMHO, there is no reason to make LocoNetSystemVariableClass methods isSVStorageValid(), readSVNodeId(), CheckAddressRange(), and writeSVNodeId() private. They should be all public ones.

The first 3 are all read-only and can be useful to use. writeSVNodeId is a high-level use of the already public writeSVStorage() and can be also quite useful.

Many thanks

Signed-off-by: Evili del Rio evili.del.rio@gmail.com

kiwi64ajs commented 4 years ago

Fair enough

positron96 commented 3 years ago

Can this be made into a new release on Arduino library manager?

kiwi64ajs commented 3 years ago

Done

On 29/11/2020, at 7:05 AM, Pavel Melnikov notifications@github.com wrote:

Can this be made into a new release on Arduino library manager?

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub https://github.com/mrrwa/LocoNet/pull/15#issuecomment-735270727, or unsubscribe https://github.com/notifications/unsubscribe-auth/AB5Y53PVC2JMZ2DELRWMGR3SSE3YNANCNFSM4N3IJLMQ.