search

mrrwa / LocoNet

An embedded Loconet interface library for Arduino family microcontrollers
Other
65 stars 32 forks source link

Last parameter for makeLNCVresponse should be 0x00 for notifyLNCVprogrammingStart #43

Open StephHamburg opened 5 months ago

StephHamburg commented 5 months ago

https://github.com/mrrwa/LocoNet/blob/bb77a7a2c0f746bc802339bede5f529150f32b4d/LocoNet.cpp#L1924

Thanks for the great LocoNet implementation! Used it for the new Faller Car System. Please check the last parameter at

makeLNCVresponse(response.ub, LnPacket->ub.SRC, LnPacket->ub.payload.data.deviceClass, 0x00, LnPacket->ub.payload.data.lncvValue, 0x80); [It has already been changed in two similar places]

for notifyLNCVprogrammingStart. Needed to change it from 0x80 to 0x00 to get it running.