Fix comments in NmraDcc.h

mrrwa / NmraDcc

NMRA Digital Command Control (DCC) Library

GNU Lesser General Public License v2.1

135 stars 53 forks source link

Fix comments in NmraDcc.h #53

Closed FrightRisk closed 3 years ago

FrightRisk commented 3 years ago

Fix notifyDccAccTurnoutOutput() comments to show this is used when CV29_OUTPUT_ADDRESS_MODE IS set. Add emphasis to this and notifyDccAccTurnoutBoard() similar routine. Related to this Issue: https://github.com/mrrwa/NmraDcc/issues/52

ghost commented 3 years ago

Congratulations :tada:. DeepCode analyzed your code in 2.377 seconds and we found no issues. Enjoy a moment of no bugs :sunny:.

👉 View analysis in DeepCode’s Dashboard | Configure the bot

kiwi64ajs commented 3 years ago

We probably also want to remove the line 525: https://github.com/mrrwa/NmraDcc/blob/681b362811d7c25accc93222d22dacfb52412fcf/NmraDcc.h#L525

Decoders of this type have 4 paired turnout outputs per board.

As that isn't relevant to: notifyDccAccTurnoutOutput() either