Enabling SSL connection in mongotail

mrsarm / mongotail

Command line tool to log all MongoDB queries in a "tail"able way

https://pypi.org/project/mongotail/

GNU General Public License v3.0

192 stars 17 forks source link

Closed sharma-abhishek closed 8 years ago

sharma-abhishek commented 8 years ago

Hi,

Following are the changes for enabling SSL in mongotail:

added ssl options to the connection parameters, as per the https://api.mongodb.com/python/current/api/pymongo/mongo_client.html#pymongo.mongo_client.MongoClient
updated README.rst for the reference.
UPDATED connect method with args to pass more parameters and did the changes required in the function definition accordingly.

I have checked it on my side to ensure the SSL connection is working.

Kindly look the changes and let me know if any changes required from my side.

Thanks, Abhishek

mrsarm commented 8 years ago

Thanks @sharma-abhishek, sorry for the late response, I will see your pull request as soon as possible to merge for the next version.

mrsarm commented 8 years ago

@sharma-abhishek I did the merge, and added some minor changes:

Changed underscore style by camelCase style for SSL option names. I don't really like this style for command line options, but it's used by the mongo command line tool, so I try to use the same syntaxis of that command as much as possible. See this.
Shorter help option texts.
Fixed PEP8 issues. Minor, isn't important, but PyCharm did the work for me :-)

Thanks for the contribution, I will add some more patches and release the 2.0.0 version with this.