search

mrseanryan / tslint-folders

:file_folder: Use tslint to check for invalid imports between packages and folders in your TypeScript project. Automatic validation and documentation of package architecture.
MIT License
9 stars 1 forks source link

feat: Add support for slashes in package name #31

Closed WiseBird closed 3 years ago

WiseBird commented 3 years ago
  1. Added support for slashes in package names Changes are in ImportRuleUtils::determinePackageName. Instead of assuming that the first part is a package we look for the biggest portion that corresponds to an existing package.
  2. Added support for /* in tsconfig paths as it often used there. Changes are in AbsoluteImportResolver::resolvePathToPackageName.
  3. Fixed small issue in coverage test run - no need to skip some of the tests Was caused by glob.sync returning relative path that lead to a failure of startsWith check in AbsoluteImportResolver::resolvePathToPackageName

fix #26

mrseanryan commented 3 years ago

@WiseBird looks good!

Because I use semantic-release to do the publishing, can you please add a commit that has this format:

feat: Add support for slashes in package name

(or if you prefer, you can amend an existing commit)

Then, when I merge to master, it will correctly update the package version, when it publishes.

Thank you for contributing! Sean

WiseBird commented 3 years ago

I actually used commit.sh to commit.

WiseBird commented 3 years ago

@mrseanryan Done

mrseanryan commented 3 years ago

:tada: This PR is included in version 4.1.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket: