errors deploying with recent changes

mrserverless / serverless-golang

AWS Lambda Go functions using Serverless Framework and Python shim

Other

302 stars 21 forks source link

Closed kmarquardsen closed 6 years ago

kmarquardsen commented 6 years ago

@yunspace

make: dep: Command not found
make: *** [_deps] Error 127
make: *** [deps] Error 2

mrserverless commented 6 years ago

thanks, I thought I pushed a fix in the docker image but obviously not... looking into it...

kmarquardsen commented 6 years ago

👍 no worries. I glanced at the changes but it wasn't immediately obvious. Let me know if I'm just missing something

mrserverless commented 6 years ago

epic fail on my side. I committed https://github.com/yunspace/serverless-golang/commit/fec09f04d2eb54f6ec2839b6f17350617b51e358 but it was building latest in docker hub and I didn't re-tag 1.21.1 properly.

Please delete the old image docker rmi yunspace/serverless-golang:1.21.1 and re-try.

kmarquardsen commented 6 years ago

thanks! all good now

mrserverless commented 6 years ago

Awesome, I think I will need to add more tests and CI around this going forward.