mrshmllow / BetterRecipeBook

Adds brewing, smithing, and QOL changes to the vanilla recipe book!
https://curseforge.com/minecraft/mc-mods/brb
MIT License
21 stars 8 forks source link

Random crash #112

Closed sternschnaube closed 6 months ago

sternschnaube commented 6 months ago

What happened?

Jumped down, 6 to 8 blocks, got damage and Minecraft crashed.

Modloader

Fabric (Default)

Minecraft Version

1.20.2

Mod Version

brb-1.10.0+1.20.2

Relevant log output

java.lang.ArithmeticException: / by zero
    at net.minecraft.class_513.handler$zpn000$brb$render(class_513.java:2056)
    at net.minecraft.class_513.method_2634(class_513.java)
    at net.minecraft.class_507.method_25394(class_507.java:304)
    at net.minecraft.class_490.method_25394(class_490.java:84)
    at net.minecraft.class_437.method_47413(class_437.java:110)
    at net.minecraft.class_757.method_3192(class_757.java:946)
    at net.minecraft.class_310.method_1523(class_310.java:1275)
    at net.minecraft.class_310.method_1514(class_310.java:856)
    at net.minecraft.client.main.Main.main(Main.java:253)
    at net.fabricmc.loader.impl.game.minecraft.MinecraftGameProvider.launch(MinecraftGameProvider.java:470)
    at net.fabricmc.loader.impl.launch.knot.Knot.launch(Knot.java:74)
    at net.fabricmc.loader.impl.launch.knot.KnotClient.main(KnotClient.java:23)
mrshmllow commented 6 months ago

that sounds insane and impossibly to debug probably packets from the server unlocking recipes or something @TauCubed any ideas

sternschnaube commented 6 months ago

I think it's now the second time that I encounter this bug. Or maybe even the third time.

It comes from the rare side and the priority can be set really low - but I wanted to report 😊

TauCubed commented 6 months ago

that sounds insane and impossibly to debug probably packets from the server unlocking recipes or something @TauCubed any ideas

It was caused by scrolling with an empty recipe book page.

TauCubed commented 6 months ago

I noticed that you are using version 1.20.2 (I misread it as 1.20.4) could you please test that this crash happens in that version when the following conditions are met?

Thank you.

sternschnaube commented 6 months ago

I have to thank you, tested it right now and Minecraft instantly crashed. Good that I know now, what to avoid 😂

sternschnaube commented 6 months ago

Thanks for the fast fix - do you plan to publish this version soon?