search

mrshmllow / BetterRecipeBook

Adds brewing, smithing, and QOL changes to the vanilla recipe book!
https://curseforge.com/minecraft/mc-mods/brb
MIT License
21 stars 8 forks source link

[Bug]: Other mods can't modify whether toasts have sound or not #138

Open antieksi opened 1 month ago

antieksi commented 1 month ago

What happened?

I use a mod called Music Notification. The mod has an option to turn off popup sound for either only its toasts or for all toasts that do exist in the game. Unfortunately, seems like BRB prevents mods from modifying toast sound behavior — and I mean any mods, because it also happened to me a while ago, though while I was using different mods that edit the processes behind playing music (I don't remember which ones was I using at the time, and looks like they never updated from 1.19.4).

If this can be useful, here's an original issue I made on Music Notification's issue tracker: https://github.com/KosmoMoustache/MusicNotification/issues/41

Modloader

Fabric (Default)

Minecraft Version

1.20.1

Mod Version

v1.10.0+1.20.0-1

Relevant log output

None
mrshmllow commented 1 month ago

I think affecting all toasts is out of scope for this mod these days.