search

mrshmllow / BetterRecipeBook

Adds brewing, smithing, and QOL changes to the vanilla recipe book!
https://curseforge.com/minecraft/mc-mods/brb
MIT License
21 stars 8 forks source link

Update to 1.20 #68

Closed TauCubed closed 1 year ago

TauCubed commented 1 year ago

Hello! Once again decided to update this for me and my friends personal use and thought I'd put it here for others to compile/update from.

While all of the mods functionality seems to work, It's only had basic tests done on fabric, and forge hasn't been tested at all.

mrshmllow commented 1 year ago

:heart: Will check out soon

CatchingPhoenix commented 1 year ago

Hello TauCubed. I am admittedly a major novice, but I'd like to use your file and can't figure out how to get a .jar file on github for 1.20 like you say you have. Could you instruct me/point me to where I can download the mod?

mrshmllow commented 1 year ago

Hey @CatchingPhoenix! Welcome to GitHub!

This post is simply proposing changes, and once I accept them (soon), I will post a release where you will be able to download the mod for 1.20.

TauCubed commented 1 year ago

Hello TauCubed. I am admittedly a major novice, but I'd like to use your file and can't figure out how to get a .jar file on github for 1.20 like you say you have. Could you instruct me/point me to where I can download the mod?

You would need to compile the mod yourself.

  1. Download my update-1.20 branch
  2. Make sure you have JDK 17 or greater installed. (you can check by running java --version)
  3. Run ./gradlew build in terminal/cmd to build a jar for both fabric and forge.
  4. You can find the jars in the ./(fabric or forge)/build/libs/ folder.

If you are not comfortable installing new JREs/JDKs then I would just wait for the release of the mod.

mrshmllow commented 1 year ago

The biggest issues remaining seem to be potion UI graphical ones. Ingredient previews are sometimes wrong and some textures are broken there too

image

image

But besides those, the rest of the functionality is perfect on fabric from what ive seen, but forge doesnt launch for me

TauCubed commented 1 year ago

Interesting. I'll look into that on the weekend.

TauCubed commented 1 year ago

There are still some things unfinished. Such as client side place recipes for the crafting table, potion comparison for ghost recipes is not yet finished, among some other things.

TauCubed commented 1 year ago

I tested it on forge and fabric (as well as on a paper backend with GrimAC) and it seems to work as intended.

This should also fix #47

mrshmllow commented 1 year ago

Awesome, do you consider it completed?

TauCubed commented 1 year ago

While there is always room for improvement (which I tend to get carried away with) I would say that it's definitely updated to 1.20 :)

About the only thing I was thinking of changing was the recipe book updating after instant crafting something. Perhaps it only updates after you move your mouse off of the recipe. But it's probably something for a future PR.

mrshmllow commented 1 year ago

They yearn for the 1.20 so I think its great for now. Will publish versions later today