url_matcher: Fixed issues with file size check

mrshu / brutal-plugins

A set of plugins for brutal, the mighty chatbot

Apache License 2.0

4 stars 2 forks source link

Closed mrshu closed 9 years ago

mrshu commented 9 years ago

Sometimes there is (obviously) no 'content-length'. This commit tries to prevent those situations when it could be missing.

Signed-off-by: mr.Shu mr@shu.io

mrshu commented 9 years ago

to @pepol @Adman

pepol commented 9 years ago

lgtm

pepol commented 9 years ago

However, what if this response (without content-length) is too big? Let's say 100 GB?

mrshu commented 9 years ago

@pepol then the problem is on another level =)

In my tests this only concerns https:// URLs. In that case there is not really too much we can do about it.

pepol commented 9 years ago

@mrshu maybe a stupid question but why is Content-length problem in HTTPS?

Adman commented 9 years ago

LGTM

mrshu commented 9 years ago

@pepol very good question.

I have no idea, really. Anyhow, if we do not know the size from what there is in headers that's about everything we can do.