Closed Adman closed 9 years ago
@mrshu @pepol
LGTM, any comments @mrshu?
I do not think I like the fact that we will include calendar_sk.py
among plugins even though there is no brutal plugin code in it. In my book this should be its own module, preferably on pipy or somewhere else, so that it can be include in requirements.txt
.
When we came up with the idea for sup
it was centered around the fact that you would use it as a default ping to any of your bots, and your bots would respond with responses from given commands. The whole sup
command would in the end become just one big alias. This is based on the idea that separate commands are small, well tested (huh) and can be built upon.
@Adman I am not sure whether you share my view on this but I believe this discussion has to happen somewhere.
For now though, except for that module it LGTM.
@mrshu yeah, you are right. Sup command should call other commands and return the message joined with commas for instance. I shoud probably rename this plugin to !dayinfo . That would suit the purpose of this plugin.
I disagree with the idea that calendar_sk should be a module. It's something like config file. I recommend creating a folder where each plugin would handle its own config file for stuff like these ones.
@Adman I do not see how calendar_sk is something like a config file but maybe I am looking at it from a wrong angle.
Can you provide a little more context?
@Adman ping
@mrshu Going to make it as a module
@mrshu bump,
@mrshu bump
@Adman apart from that one comment, looks good.
@mrshu I added the option for specifying date. If everything is okay, I will squash all the commits
@Adman I do not see any issues, feel free to squash it and I'll merge it.
Thanks!
@mrshu Should be done
Signed-off-by: Adrian Matejov a.matejov@centrum.sk