search

mrshu / brutal-plugins

A set of plugins for brutal, the mighty chatbot
Apache License 2.0
4 stars 2 forks source link

autowelcome: Refactored autowelcomes into class. #108

Closed JakubNvk closed 8 years ago

JakubNvk commented 9 years ago

Issue: #77 To: @mrshu

pepol commented 9 years ago

@JakubNvk I'm not sure whether I missed it or not, but there should also be an event type function to actually welcome users on channel, am I right?

JakubNvk commented 9 years ago

@pepol oh right, I completely forgot about that :D

mrshu commented 9 years ago

@JakubNvk I get what you tried to do here but I'd like you to also consider my view on this.

First of all, I believe that the relevant lines below this one should be removed. Secondly, I think that the best way of giving the plugin user a way of changing the welcome messages should be via editing the config.py file which should really be the single entry point for changing any configuration of brutal plugins. You can acces the confing in a similar way weather.py plugin does (https://github.com/mrshu/brutal-plugins/blob/master/weather.py#L84).

Since your PR enables everyone to set their own welcome mesages, a good question is which welcome (user specified or config specified) should be used? My personal stance is that the welcome messages are the priviledge of the bot adinistrator. I am not sure how to merge these two data sources, unless we come up with a way of saving altered values back to the config.py file.

@JakubNvk @pepol @Adman what do you think?