mrshu / brutal-plugins

A set of plugins for brutal, the mighty chatbot
Apache License 2.0
4 stars 2 forks source link

update: Added first version of RSS plugin #113

Closed mrshu closed 9 years ago

mrshu commented 9 years ago

Signed-off-by: mr.Shu mr@shu.io

mrshu commented 9 years ago

to @Adman, @pepol

mrshu commented 9 years ago

Per our discussion with @adman I added link shortening.

Adman commented 9 years ago

@mrshu I would suggest shortening the url only if its length is more than XY characters

mrshu commented 9 years ago

@Adman that's a very good point. Would something like 50 characters work? Or maybe just 30?

Also, I am wondering though whether it (the fact that we are in fact shortening URLs) should be configurable.

mrshu commented 9 years ago

@Adman allright, I've made it configurable and set the length to 50. It worked pretty well in my tests.

Adman commented 9 years ago

@mrshu isn't 50 too many?

mrshu commented 9 years ago

@Adman considering that http:// combined with the final slash is already 8 characters I do not think so.

Also, let me note here that given the amount of variables that are configurable for this plugin, and the fact that there is no effective way of writing documentation for it, it would make way more sense to have each plugin as a separate Python module. That way, we could easily have configuration and the installation/development of respective plugins would be way easier too.

The only thing that is missing is their central repository. Looking around, we can see that this is the model hubot uses (https://github.com/hubot-scripts). So what we might do would be to have these plugins under one organization (to which all of the collaborators to this repository would have the same rights as they currently have to this repository) and also we would tag these packages with a special brutal-plugin tag or something like that. That way, you could easily search for these packages on pypi.

@Adman @JakubNvk @pepol thoughts?

Adman commented 9 years ago

lgtm

mrshu commented 9 years ago

@Adman I refactored what you asked for, feel free to punch the big green button.