Basic: Temporary fix for name matching problem. - Githubissues

mrshu / brutal-plugins

A set of plugins for brutal, the mighty chatbot

Apache License 2.0

4 stars 2 forks source link

Basic: Temporary fix for name matching problem. #33

Closed JakubNvk closed 9 years ago

JakubNvk commented 9 years ago

Signed-off-by: Jakub Novak jakub.novak@gmail.com

mrshu commented 9 years ago

@JakubNvk could you please add a comment on why this change is necessary to the commit message?

Other than that this makes sense.

JakubNvk commented 9 years ago

@mrshu ok, will do.

mrshu commented 9 years ago

@JakubNvk can you please squash your commits into one?

mrshu commented 9 years ago

@JakubNvk this looks good, please just squash those commits into one. Thanks!

pepol commented 9 years ago

@mrshu: Merging this since it's done.

mrshu commented 9 years ago

@pepol I suppose we can live with two commits for such a simple thing. Thanks for merging this.

pepol commented 9 years ago

@mrshu I checked and the second commit is a merge one. I think that one is better on its own.

mrshu commented 9 years ago

@pepol yeah, that's probably right.