vote: vote to kick, ban, mute, ask question

[Adman]

• ability to vote to kick/ban/mute user. others are able to agree !yes or disagree !no
• ability to ask yes/no question.
• ability to ask question expecting some answer.
• showing results after vote is finished

Signed-off-by: Adrian Matejov a.matejov@centrum.sk

[Adman]

to @mrshu @pepol @JakubNvk

[mrshu]

@Adman Thanks a lot for this. I only have three questions, apart from those rised above.

1. Rather than punishment I'd probably call it a result because that's what the output of a vote is after all (at least so I believe).
2. While I understand the point of having voting and voting_q, in my book it would be far better to have some enumerated constants at the top of the file and then having just voting which would either be of the value VOTING_NONE or VOTING_YESNO or VOTING_QUESTION and so on and so on.
3. If I used something like this in a chatroom I'd probably want to be able to have a voting span over more than 60 seconds. Would it be possible to make this time configurable? Also, how hard would it be to make this work in paralel? That is, it would be cool if we could have N votings take place at any given time and the !yes and !no methods would deal with that by taking an argument which would uniquely identify a voting. If you decide to go this way it would be also good to have a way od listing a voting by this unique identifier.

[Adman]

@mrshu Everything what you mentioned should be done.

• user is now able to modify time of voting (in seconds)
• docs, example queries

[mrshu]

@Adman cool, thanks!

The only thing I have is that the penalty is no longer just penalty.

If this looks good to @pepol I think we can merge this.

[mrshu]

@Adman of course, it needs to be squashed first.

[pepol]

@Adman, apart from that one question, LGTM. Did you test this?

[Adman]

@mrshu Not sure what you mean that penalty is no longer penalty @pepol yep

[mrshu]

@Adman sorry, I must have misinterpreted something, feel free to scratch my comment.

[Adman]

Commits squashed

[Adman]

@mrshu Time in votekick, voteban, votemute, votekickban is now configurable

[mrshu]

@Adman still a couple of questions, mostly nitpicks.

[mrshu]

@Adman if you are OK with the current state and merging this won't break @pepol's heart I believe we can proceed.

[Adman]

@mrshu I will let you know tomorrow. Going to deeply think whether I'm able to refactorize yesses/nos

[pepol]

@mrshu my heart was broken long ago, don't worry about that :-D

[mrshu]

@Adman any progress?

[Adman]

@mrshu yes, kinda refactored

[Adman]

@mrshu @pepol if it's okay, I can squash commits

[mrshu]

@Adman a couple of nitpicks from me, other than that it looks good.

Let's see what @pepol has to say about this before you squash those commits.

[pepol]

@Adman fix those issues @mrshu pointed out and let's squash them, break their shields, their bones, keep them together, failed at the battlefield. :-D

[Adman]

@mrshu @pepol done, squshed

[mrshu]

@Adman nah, let's go with it.