search

mrsimpson / energy

A calculator for cost of energy (gas)
https://gaspreis.no-panic.org
Apache License 2.0
3 stars 0 forks source link

Warnings from plugin-vue when it tries to resolve xml tags #56

Closed jschirrmacher closed 1 year ago

jschirrmacher commented 1 year ago

@vite/plugin-vue tries to resolve the xml+svg paragraph icon as vue template tags. This obviously fails and creates warnings in the dev console of the browser.

I already tried to configure the plugin-vue to exclude xml files but to no avail. Now, I don't have any idea, how to resolve that.

Actually, the implementation of the menu doesn't really looks like how vue components should be implemented IMO. How about using simple <router-link>s with an icon instead of the menu? We don't currently need the features of the <n-menu>, and I think it will never be necessary.

mrsimpson commented 1 year ago

Id not swap the menu on the top (as it works well and looks good), but in the footer, simple router links are probably sufficient. I'd just not ~waste~ invest any energy into non-functional stuff (aka "quality") at the moment ;-)

jschirrmacher commented 1 year ago

Agreed. We could also have a look at vite-svg-loader. That would simplify things a lot.

jschirrmacher commented 1 year ago

I've updated the footer with #71 - I think we should close this ticket now