always use mkdir -p; remove -v (causing go errors)

mrsixw / concourse-rsync-resource

concourse.ci resource for persisting build artifacts on a shared storage location with rsync and ssh.

Apache License 2.0

18 stars 40 forks source link

always use mkdir -p; remove -v (causing go errors) #7

Closed msarahan closed 7 years ago

msarahan commented 7 years ago

Reduces the chmod to one call; removes -v from mkdir calls.

If -v is present and a folder is created, we can end up tripping up Concourse, which is expecting only JSON output on stdout. The output from the folder creation results in an error message like

invalid character 'c' looking for beginning of value

Alternatively, you could slap 1>&2 onto the mkdir -vp command. Let me know if you'd prefer that.

mrsixw commented 7 years ago

Thanks for this, I think the -v was a debug remnant. I've merged the PR and dockerhub is building the update.