Closed sea-bass closed 1 year ago
@sea-bass, thank you very much for all the feedback. I have worked on all the points that you have mentioned above:
Let me know what you think. And again, thank you for your time!
Somehow the editorialbot on the original issue isn't updating the paper, but I took a look at the updated markdown file for now.
It's looking good, I still have some additional comments.
Excellent! Thank you for the feedback!
These are the points that I have worked on:
Let me know what you think. And again 😃 , thank you for your time!!
PS: If you have an issue downloading the updated paper, you can access the actions and download the pdf from the Artifacts section.
Thank you! I really like your latest changes, and especially good to see you added the repulsion behavior to your example.
Only 2 remaining comments:
Great! I have split this paragraph into two: (1) from lines 31 to 39; and (2) from lines 39 to 55.
I did not get the idea in "your post-table paragraphs are better at the beginning". As I understood, are you talking about the paragraphs after the table (the statement of need)?
I did not get the idea in "your post-table paragraphs are better at the beginning". As I understood, are you talking about the paragraphs after the table (the statement of need)?
Yes, exactly! I think introducing the difference between simulation and behavior packages before going through the list and table may work better. Very minor.
Thank you for submitting pyswarming to JOSS! As one of your reviewers, I'll collect a few issues here with the paper submission itself.
General Comments
I think the "Related Software Packages" section should come in earlier in the paper, before you introduce PySwarming. This should serve as part of your introduction leading to the "meat" of the paper, and meet the JOSS expectation below:
Do the authors have any other published work that uses PySwarming? If so, it's a great opportunity to include this in the references, if it has not yet been added.
Lastly, the paper is missing a conclusion! Please add one.
Summary
The summary seems like it abruptly switches from an introduction to swarm robotics to a list of things that PySwarming can do. Consider making this a bit more gentle by following a layout like this:
On the note of "briefly say what the tool does", I think in your summary the citations to leaderless coordination, preferred direction, aggregation, etc. Consider talking about these algorithms in a separate section. Most papers will have
Example Usage
I like this section! The only thing I would suggest here is maybe adding more details about how a user might use this tool to create their own new behaviors. The paper advertises that PySwarming is flexible and easy to extend, so it's worthwhile to talk about that a little bit.
Related Software Packages
https://github.com/openjournals/joss-reviews/issues/5647