Phase 2 Support - Githubissues

mrsool / zatca

An unofficial Ruby library for generating ZATCA e-invoices, QR Codes, and submitting e-invoices to ZATCA's servers.

MIT License

40 stars 16 forks source link

Phase 2 Support #15

Closed obahareth closed 11 months ago

obahareth commented 2 years ago

Support for #11 and #8.

[x] Wrap all API endpoints (V2)
[x] Add and test modules to serialize to required formats
- [x] Simplified invoice
- [x] Standard invoice
[x] Cryptographic stamp
[x] Hashing invoices
[x] Update version with breaking change due to bump to Ruby 2.5 as the minimum supported version
[x] Dockerize ZATCA's SDK for running it easily
[x] Fix XML sample that's generated by the SDK to go through ZATCA's validator (there's a signing error)

Update Wiki with

[x] Samples of requests (Partially done)
[x] Getting credentials
[x] Constructing an invoice
[x] Checking invoice compliance
[x] Links to ZATCA docs

For a future PR

[ ] Add request specs

obahareth commented 1 year ago

The latest SDK ZATCA shared with me has no samples that pass their own CLI or web validators, I just want to make sure I get a passing result before I merge this.

Otherwise the XML is structurally sound (validated by them and PWC in a call), the signing is correct, the new QR code is correct, etc.

I just want to get a passing validation from their SDK.

obahareth commented 1 year ago

So far results are very good. All the XML generated by the SDK is passing in terms of structure, there's just one error in the signature that's causing an issue.

I am in daily contact with ZATCA to get it resolved.

Once that's done we're good to go. In a future PR I will probably add helpers to help construct invoice type codes, payment means, etc.

obahareth commented 1 year ago

Good news, this is passing ZATCA's compliance checks. I'm just doing some final updates to the wiki and verifications and will be merging this in the coming weeks.