search

mrsudarshanrai / QR-code-generator

This is a simple web code to generate QR code,powered by chart.apis.google
https://mrsudarshanrai.github.io/QR-code-generator/
MIT License
8 stars 8 forks source link

QR not generating when number is large #14

Open vaibhava17 opened 1 year ago

vaibhava17 commented 1 year ago

I will add a specific limit to the number field with error message on submitting. Which will help in handling this issue.

image
mrsudarshanrai commented 1 year ago

@vaibhava17 You can work on it.

Ashish89088 commented 1 year ago

Is this issue still open, I want to work on this

Ashish89088 commented 1 year ago

Hi I have Fix this Issue and send you the pull request. please review my code and merge my pull request.

vaibhava17 commented 1 year ago

@Ashish89088 i have already done that and they are not active

Ashish89088 commented 1 year ago

Yes I have seen that you have taken mod with 400 , but this code is running fine for all inputs. Your case fails when user enters suppose 401 , so 401%400 = 1 , and for this size the qr is not showing. I have bounded the range of input in the range of [200,400] .

Ashish89088 commented 1 year ago

I am attaching the screenshots for two different input. The QR is now shown for all types of input. Please review this and run it for different testcases once. Screenshot (682) Screenshot (681)