search

mrsum / webpack-svgstore-plugin

Simple svg-sprite creating with webpack
https://www.npmjs.com/package/webpack-svgstore-plugin
200 stars 92 forks source link

Support assetsPublicPath in webpack config #106

Open gendalf opened 8 years ago

gendalf commented 8 years ago

When assetsPublicPath in webpack isnt "/", module not add it to svg url in xhr

mrsum commented 8 years ago

@gendalf you are right. which logic u expect?

gendalf commented 8 years ago

assetsPublicPath = "/" svg = { path : "assets/svg.." } Injected with path http://.../assets/svg... = 200

assetsPublicPath = "/clientroom" svg = { path : "assets/svg.." } Injected with path http://.../assets/svg... = 404 But can access by http://.../clientroom/assets/svg.. = 200

assetsPublicPath = "/clientroom" svg = { path : "clientroom/assets/svg.." } Injected with path http://.../clientroom/assets/svg... = 404