use webpack`s public path at runtime to resolve sprite url

mrsum / webpack-svgstore-plugin

Simple svg-sprite creating with webpack

https://www.npmjs.com/package/webpack-svgstore-plugin

200 stars 92 forks source link

use webpack`s public path at runtime to resolve sprite url #110

Closed ggarek closed 7 years ago

ggarek commented 8 years ago

fix issue #109

chicoxyzzy commented 7 years ago

@mrsum @lgordey can you guys take a look please? We really need this

mrsum commented 7 years ago

@chicoxyzzy got it

mrsum commented 7 years ago

@ggarek @chicoxyzzy sorry for delay guys, can some one bump version into package.json to 3.0.5

chicoxyzzy commented 7 years ago

This change introduces breaking change as mentioned in #109. So it shouldn't be 3.0.5 if you follow SemVer 😃

ggarek commented 7 years ago

@chicoxyzzy that's right @mrsum moreover before applying the change some more work should be done, considering it is a breaking change. (i mean the window.baseUrl magic)